tests: remove unsupported TS integration tests #20359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested review from
devversion,
jelbourn and
a team
as code owners
googlebot
added
the
cla: yes
devversion
added
action: merge
|
Note: CI is failing due to failures in |
alan-agius4
added
the
target: patch
With this change we remove TS integration tests for unsupported TS versions. Angular version 10 doesn't TS versions older than TS 3.9.
The current version of system.js used doesn't seem to handle the `exports` correctly for TypeScript 3.9 output and causes `Cannot find variable: exports` during runtime. With this change we change the tests module to use UMD.
Since we are installing multiple TS versions https://github.com/angular/components/blob/1f6b90c0a515397526d7c6b35f047827bfaa8652/package.json#L170-L173 yarn will link the last tsc binary which may not be the TSC version we want to use to build/test this reproduction. Currently with the following package.json packages ``` "typescript": "3.9.5", "typescript-3.6": "npm:typescript@~3.6.4", "typescript-3.7": "npm:typescript@~3.7.0", "typescript-3.8": "npm:typescript@~3.8.0", ``` If we run `npx tsc --v` the output will be `Version 3.8.3` as opposed to `3.9.5`
wagnermaciel
pushed a commit
that referenced
this pull request
Aug 20, 2020
* test: remove unsupported TS integration tests With this change we remove TS integration tests for unsupported TS versions. Angular version 10 doesn't TS versions older than TS 3.9. * build: update to TypeScript 3.9.7 * build: update tests to use UMD module format The current version of system.js used doesn't seem to handle the `exports` correctly for TypeScript 3.9 output and causes `Cannot find variable: exports` during runtime. With this change we change the tests module to use UMD. * build: point to typescript node_modules folder instead of `.bin` Since we are installing multiple TS versions https://github.com/angular/components/blob/1f6b90c0a515397526d7c6b35f047827bfaa8652/package.json#L170-L173 yarn will link the last tsc binary which may not be the TSC version we want to use to build/test this reproduction. Currently with the following package.json packages ``` "typescript": "3.9.5", "typescript-3.6": "npm:typescript@~3.6.4", "typescript-3.7": "npm:typescript@~3.7.0", "typescript-3.8": "npm:typescript@~3.8.0", ``` If we run `npx tsc --v` the output will be `Version 3.8.3` as opposed to `3.9.5` (cherry picked from commit bbf75f3)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: point to typescript node_modules folder instead of
.binSince we are installing multiple TS versions
components/package.json
Lines 170 to 173 in 1f6b90c
Currently with the following package.json packages
If we run
npx tsc --vthe output will beVersion 3.8.3as opposed to3.9.5build: update tests to use UMD module format
The current version of system.js used doesn't seem to handle the
exportscorrectly for TypeScript 3.9 output and causesCannot find variable: exportsduring runtime.With this change we change the tests module to use UMD.
build: update to TypeScript 3.9.7
test: remove unsupported TS integration tests
With this change we remove TS integration tests for unsupported TS versions.
Angular version 10 doesn't TS versions older than TS 3.9.