Skip to content

build: use new labeling and branching in merge script #20295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

We introduced a new shared configuration for merge script
labels that follow the new proposal:

https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU

These label semantics and the new branching are set up for the Angular
Components repository with this commit. The goal is that labeling and
merging is consistent between all Angular projects and that clear rules
are defined for branching/labeling. This was previously not the case

We introduced a new shared configuration for merge script
labels that follow the new proposal:

https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU

These label semantics and the new branching are set up for the Angular
Components repository with this commit. The goal is that labeling and
merging is consistent between all Angular projects and that clear rules
are defined for branching/labeling. This was previously not the case
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Aug 13, 2020
@devversion devversion requested a review from a team as a code owner August 13, 2020 12:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 13, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2020
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 13, 2020
@andrewseguin andrewseguin merged commit c063fbc into angular:master Aug 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants