build: do not prompt on postinstall in bazel yarn install #20294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when Bazel runs the Yarn postinstall, we might prompt if the postinstall patches have been modified. This prompt runs forever as there is no input TTY. We fix this by not prompting if there is no TTY. i.e. always cleaning up the node modules in that case.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
pushed a commit
that referenced
this pull request
Aug 13, 2020
Currently when Bazel runs the Yarn postinstall, we might prompt if the postinstall patches have been modified. This prompt runs forever as there is no input TTY. We fix this by not prompting if there is no TTY. i.e. always cleaning up the node modules in that case. (cherry picked from commit 5f87552)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Bazel runs the Yarn postinstall, we might
prompt if the postinstall patches have been modified.
This prompt runs forever as there is no input TTY. We fix
this by not prompting if there is no TTY. i.e. always cleaning
up the node modules in that case.