Skip to content

fix(progress-spinner) add theme for mdc-progress-spinner #20170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2020
Merged

fix(progress-spinner) add theme for mdc-progress-spinner #20170

merged 1 commit into from
Sep 5, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Aug 3, 2020

previously excluded in #20048 to keep it merge safe

@annieyw annieyw requested a review from mmalerba as a code owner August 3, 2020 19:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 3, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Aug 3, 2020

Can you change commit message to fix(progress-spinner) add theme for mdc-progress-spinner

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Aug 3, 2020
mmalerba
mmalerba approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw changed the title prototype(progres-spinner) add theme for mdc-progress-spinner fix(progress-spinner) add theme for mdc-progress-spinner Aug 3, 2020
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2020
@andrewseguin andrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label Aug 18, 2020
@mmalerba mmalerba merged commit faddbaa into angular:master Sep 5, 2020
mmalerba pushed a commit that referenced this pull request Sep 5, 2020
@annieyw @mmalerba
prototype(progres-spinner) add theme for mdc-progress-spinner (#20170)
a307cf1 
(cherry picked from commit faddbaa)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2020
@annieyw annieyw deleted the add-theme branch November 9, 2020 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annieyw @mmalerba @googlebot @andrewseguin