Skip to content

chore: check in firebase function used for populating caretaker app #20120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

josephperrott
Copy link
Member

Previously the caretaker app's firebase function were only stored
locally on a computer rather than checked into github. Checking in
the currently running code provides us with a bit more resilience
long term around any issues with redeployments and deprecations.

New fields have been added to the synced information from each PR
in the caretaker application.  This change updates the resync script
to also include these new fields.
Previously the caretaker app's firebase function were only stored
locally on a computer rather than checked into github. Checking in
the currently running code provides us with a bit more resilience
long term around any issues with redeployments and deprecations.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Jul 28, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 28, 2020
@josephperrott josephperrott marked this pull request as ready for review July 28, 2020 22:19
@josephperrott josephperrott requested a review from a team as a code owner July 28, 2020 22:19
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit a79a71d into angular:master Jul 29, 2020
jelbourn pushed a commit that referenced this pull request Jul 29, 2020
…20120)

* chore: update caretaker resyncing script to include new fields.

New fields have been added to the synced information from each PR
in the caretaker application.  This change updates the resync script
to also include these new fields.

* chore: check in firebase function used for populating caretaker app

Previously the caretaker app's firebase function were only stored
locally on a computer rather than checked into github. Checking in
the currently running code provides us with a bit more resilience
long term around any issues with redeployments and deprecations.

(cherry picked from commit a79a71d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants