Skip to content

build: increase timeout for resultstore build uploads #20027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

devversion
Copy link
Member

We upload build results to Google Cloud ResultStore. Sometimes this
seems to fail though and Bazel CI jobs exit red. This could be due to
BES servers being slow, or servers being unreliably. Given that remote
executors from GCP are behaving fine though, we try increasing the
timeout first. We can disable the uploading if it doesn't get better.

For context: We upload to result store / source.cloud.google.com so that
CI builds with Bazel can be debugged better. e.g.

https://source.cloud.google.com/results/invocations/410a5790-54eb-43e8-96eb-c3cfa0f8960d

@devversion devversion requested a review from a team as a code owner July 17, 2020 15:32
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 17, 2020
We upload build results to Google Cloud `ResultStore`. Sometimes this
seems to fail though and Bazel CI jobs exit red. This could be due to
BES servers being slow, or servers being unreliably. Given that remote
executors from GCP are behaving fine though, we try increasing the
timeout first. We can disable the uploading if it doesn't get better.
@devversion devversion force-pushed the build/disable-bes-results branch from 926dd19 to 614258e Compare July 17, 2020 15:32
@devversion devversion added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 17, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 17, 2020
@andrewseguin andrewseguin merged commit 5026981 into angular:master Jul 17, 2020
andrewseguin pushed a commit that referenced this pull request Jul 17, 2020
We upload build results to Google Cloud `ResultStore`. Sometimes this
seems to fail though and Bazel CI jobs exit red. This could be due to
BES servers being slow, or servers being unreliably. Given that remote
executors from GCP are behaving fine though, we try increasing the
timeout first. We can disable the uploading if it doesn't get better.

(cherry picked from commit 5026981)
ngwattcos pushed a commit to ngwattcos/components that referenced this pull request Jul 20, 2020
We upload build results to Google Cloud `ResultStore`. Sometimes this
seems to fail though and Bazel CI jobs exit red. This could be due to
BES servers being slow, or servers being unreliably. Given that remote
executors from GCP are behaving fine though, we try increasing the
timeout first. We can disable the uploading if it doesn't get better.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants