Skip to content

build: fix size check failures #19815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 1, 2020

Fixes the size check failures that are breaking master.

Fixes the size check failures that are breaking master.
@crisbeto crisbeto force-pushed the size-check-failures-again branch from 9b44673 to 87b943e Compare July 1, 2020 06:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 1, 2020
@crisbeto crisbeto marked this pull request as ready for review July 1, 2020 06:33
@crisbeto crisbeto requested a review from a team as a code owner July 1, 2020 06:33
@crisbeto crisbeto added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 1, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For later context: This change caused the size increase for overlay-based components: 210d054

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 1, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 1, 2020
@jelbourn
Copy link
Member

jelbourn commented Jul 1, 2020

Changing to minor because the PR that affected this was not cherry-picked into 10.0.x

@jelbourn jelbourn merged commit dfc279f into angular:master Jul 1, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants