build: add custom linting for symbol names #19811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, we want to prefix some exported class names with an underscore so it's more obvious that they're private. The problem is that our current class naming rule doesn't allow for a class to start with an underscore. These changes add a custom rule that can use a regex to validate the class name. Having our own rule allows us to validate more types of nodes as well (e.g. `type` nodes which tslint doesn't check).
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
a team
as code owners
googlebot
added
the
cla: yes
devversion
approved these changes
Jul 1, 2020
jelbourn
pushed a commit
that referenced
this pull request
Jul 1, 2020
As discussed, we want to prefix some exported class names with an underscore so it's more obvious that they're private. The problem is that our current class naming rule doesn't allow for a class to start with an underscore. These changes add a custom rule that can use a regex to validate the class name. Having our own rule allows us to validate more types of nodes as well (e.g. `type` nodes which tslint doesn't check).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we want to prefix some exported class names with an underscore so it's more obvious that they're private. The problem is that our current class naming rule doesn't allow for a class to start with an underscore. These changes add a custom rule that can use a regex to validate the class name. Having our own rule allows us to validate more types of nodes as well (e.g.
typenodes which tslint doesn't check).