fix(material/tooltip): not closing when scrolling away using mouse wheel #19735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
18611/tooltip-mouse-wheel
branch
from
0406af8 to
8243485
Compare
andrewseguin
approved these changes
Jul 20, 2020
andrewseguin
added
lgtm
action: merge
crisbeto
force-pushed
the
18611/tooltip-mouse-wheel
branch
from
8243485 to
a45e03b
Compare
crisbeto
force-pushed
the
18611/tooltip-mouse-wheel
branch
2 times, most recently
from
2ee56c9 to
fb59ad3
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
18611/tooltip-mouse-wheel
branch
from
fb59ad3 to
8b8a0d1
Compare
We depend on the `mouseleave` event to close the tooltip, but it won't fire if the user scrolls away without moving their mouse. These changes add some logic so the tooltip is closed if a `wheel` event resulted in the cursor leaving the trigger. Fixes angular#18611.
crisbeto
force-pushed
the
18611/tooltip-mouse-wheel
branch
from
8b8a0d1 to
a5ac67d
Compare
annieyw
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We depend on the
mouseleaveevent to close the tooltip, but it won't fire if the user scrolls away without moving their mouse. These changes add some logic so the tooltip is closed if awheelevent resulted in the cursor leaving the trigger.Fixes #18611.