Skip to content

build: some scripts not being linted #19711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2020
Merged

build: some scripts not being linted #19711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/caretaking/resync-caretaker-app-prs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import * as Octokit from '@octokit/rest';
import * as fetch from 'node-fetch';

const apiBaseUrl = 'https://test-jperrott.firebaseio.com/pulls';
const github = new Octokit({auth: process.env.TOKEN});

async function resync() {
Expand All @@ -22,7 +23,7 @@ async function resync() {
let syncedCount = 0;
for (let pull of pulls) {
await fetch.default(
`https://test-jperrott.firebaseio.com/pulls/${pull.base.repo.full_name}/${pull.number}/github.json`,
`${apiBaseUrl}/${pull.base.repo.full_name}/${pull.number}/github.json`,
{
method: 'patch',
body: JSON.stringify({
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
"e2e/**/*.ts",
"test/**/*.ts",
"tools/**/*.ts",
"integration/**/*.ts"
"integration/**/*.ts",
"scripts/**/*.ts"
],
"exclude": [
// Exclude files that depend on Node APIs because those depend on the Node types and therefore
Expand Down