docs(select): switch examples to fill appearance #19708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Jun 20, 2020
There was a problem hiding this comment.
FYI: The appearance is not yet deprecated d550e4e, so you might want to make that more clear in the commit description/title.
Changes all of the `mat-select` examples to use a `mat-form-field` appearance that won't be deprecated in the future.
crisbeto
force-pushed
the
select-form-field-appearance
branch
from
91d839d to
4308e98
Compare
crisbeto
changed the title
|
Changed, although the old appearance is deprecated as far as the spec is concerned. |
jelbourn
pushed a commit
that referenced
this pull request
Jun 26, 2020
Changes all of the `mat-select` examples to use a `mat-form-field` appearance that won't be deprecated in the future. (cherry picked from commit 8147cc9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all of the
mat-selectexamples to use amat-form-fieldappearance that won't be deprecated in the future.