Skip to content

feat(material/chips): prevent chips from being deleted when user holds backspace #19700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 10, 2021
Merged

feat(material/chips): prevent chips from being deleted when user holds backspace #19700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c1543a3
feat(material/chips): prevent chips from being deleted when user hold…
gioragutt Jun 19, 2020
5417d34
add unit tests
gioragutt Feb 12, 2021
d84df4e
replace MatChipInputEvent.clearInput with MatChipInputEvent.chipInput…
gioragutt Feb 13, 2021
5381a7a
fix unit test to actually test wanted behaviour
gioragutt Feb 13, 2021
752dc4a
update mdc-chips/chip-input.ts
gioragutt Feb 16, 2021
755d8bc
update chip-grid, update demos and add tests to spec
gioragutt Feb 19, 2021
798e2c7
make MatChipInputEvent.chipInput temporarily optional (for backward c…
gioragutt Mar 4, 2021
a66e1e2
yarn approve-api chips
gioragutt Mar 4, 2021
373bffa
Merge remote-tracking branch 'upstream/master' into giorag/chip-list-…
gioragutt Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/components-examples/material/chips/chips-autocomplete/chips-autocomplete-example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,15 @@ export class ChipsAutocompleteExample {
}

add(event: MatChipInputEvent): void {
const input = event.input;
const value = event.value;
const value = (event.value || '').trim();

// Add our fruit
if ((value || '').trim()) {
this.fruits.push(value.trim());
if (value) {
this.fruits.push(value);
}

// Reset the input value
if (input) {
input.value = '';
}
// Clear the input value
event.chipInput!.clear();

this.fruitCtrl.setValue(null);
}
Expand Down
13 changes: 5 additions & 8 deletions src/components-examples/material/chips/chips-input/chips-input-example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,15 @@ export class ChipsInputExample {
];

add(event: MatChipInputEvent): void {
const input = event.input;
const value = event.value;
const value = (event.value || '').trim();

// Add our fruit
if ((value || '').trim()) {
this.fruits.push({name: value.trim()});
if (value) {
this.fruits.push({name: value});
}

// Reset the input value
if (input) {
input.value = '';
}
// Clear the input value
event.chipInput!.clear();
}

remove(fruit: Fruit): void {
Expand Down
13 changes: 5 additions & 8 deletions src/dev-app/chips/chips-demo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {Component} from '@angular/core';
import {MatChipInputEvent} from '@angular/material/chips';
import {ThemePalette} from '@angular/material/core';


export interface Person {
name: string;
}
Expand Down Expand Up @@ -61,17 +60,15 @@ export class ChipsDemo {
}

add(event: MatChipInputEvent): void {
const {input, value} = event;
const value = (event.value || '').trim();

// Add our person
if ((value || '').trim()) {
this.people.push({ name: value.trim() });
if (value) {
this.people.push({ name: value });
}

// Reset the input value
if (input) {
input.value = '';
}
// Clear the input value
event.chipInput!.clear();
}

remove(person: Person): void {
Expand Down
12 changes: 5 additions & 7 deletions src/dev-app/mdc-chips/mdc-chips-demo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,15 @@ export class MdcChipsDemo {
}

add(event: MatChipInputEvent): void {
const {input, value} = event;
const value = (event.value || '').trim();

// Add our person
if ((value || '').trim()) {
this.people.push({ name: value.trim() });
if (value) {
this.people.push({ name: value });
}

// Reset the input value
if (input) {
input.value = '';
}
// Clear the input value
event.chipInput!.clear();
}

remove(person: Person): void {
Expand Down
Loading