Skip to content

docs: fix syntax error in doc region #19683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

docs: fix syntax error in doc region #19683

merged 1 commit into from
Jun 18, 2020

Conversation

crisbeto
Copy link
Member

Fixes a syntax error in one of the docs that is breaking the build on master.

@crisbeto
docs: fix syntax error in doc region
4c6515c 
Fixes a syntax error in one of the docs that is breaking the build on master.
@crisbeto crisbeto requested a review from jelbourn as a code owner June 18, 2020 06:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 18, 2020
@crisbeto crisbeto added docs This issue is related to documentation merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jun 18, 2020
devversion
devversion approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should really build this stuff on PRs I assume. Concern was that this increases CI costs, but we could at least build the overviews.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 18, 2020
mmalerba
mmalerba approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit a730898 into angular:master Jun 18, 2020
mmalerba pushed a commit that referenced this pull request Jun 18, 2020
@crisbeto @mmalerba
docs: fix syntax error in doc region (#19683)
613606d 
Fixes a syntax error in one of the docs that is breaking the build on master.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@devversion devversion

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @mmalerba @googlebot