Skip to content

refactor(popover-edit): remove circular reference #19679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

refactor(popover-edit): remove circular reference #19679

merged 1 commit into from
Jul 10, 2020

Conversation

crisbeto
Copy link
Member

Reworks the popover edit module in order to avoid circular references.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 17, 2020
@crisbeto crisbeto requested review from andrewseguin and a team as code owners June 17, 2020 20:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 17, 2020
@jelbourn jelbourn requested a review from kseamon June 17, 2020 21:26
@crisbeto
refactor(popover-edit): remove circular reference
205bfb1 
Reworks the popover edit module in order to avoid circular references.
@crisbeto crisbeto force-pushed the popover-edit-circular-ref branch from 3814357 to 205bfb1 Compare July 4, 2020 14:41
@jelbourn
Copy link
Member

jelbourn commented Jul 6, 2020

@kseamon any feedback on this one?

@kseamon
Copy link
Collaborator

kseamon commented Jul 7, 2020

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 7, 2020
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 10, 2020
@mmalerba mmalerba merged commit 36d4c5d into angular:master Jul 10, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@kseamon kseamon Awaiting requested review from kseamon

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@crisbeto @jelbourn @kseamon @devversion @googlebot @mmalerba @andrewseguin