Skip to content

refactor(material-experimental): include feature targets in density mixins #19638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2020
Merged

refactor(material-experimental): include feature targets in density mixins #19638

merged 1 commit into from
Jun 15, 2020

Conversation

crisbeto
Copy link
Member

Includes a feature target when invoking the MDC density mixins. This is consistent with what we're doing everywhere else and could help us exclude some unwanted styles.

@crisbeto
refactor(material-experimental): include feature targets in density m…
05bb128 
…ixins

Includes a feature target when invoking the MDC density mixins. This is consistent with what we're doing everywhere else and could help us exclude some unwanted styles.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jun 14, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 14, 2020
devversion
devversion approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think there will be ever any animation/color styles in the density styles, but it shouldn't hurt having a more specific query. Ideally though it would even error when an unexpected query is captured.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
@andrewseguin andrewseguin merged commit 17a7a97 into angular:master Jun 15, 2020
andrewseguin pushed a commit that referenced this pull request Jun 15, 2020
@crisbeto @andrewseguin
refactor(material-experimental): include feature targets in density m…
e4f1b7d 
…ixins (#19638)

Includes a feature target when invoking the MDC density mixins. This is consistent with what we're doing everywhere else and could help us exclude some unwanted styles.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @googlebot @andrewseguin