build: switch to yaml file for size test golden #19621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P2
googlebot
added
the
cla: yes
|
Please rebase |
For consistency with other size-tests's we are going to add, we should move the nav-list one into a folder that is dedicated for list size tests.
Switches the size-test golden from a JSON file to a Yaml file. The motivation is that JSON files quickly can result in merge conflicts. This is mostly because of trailing commas that need to be added when new entries are added to the size-test golden. This should be improved with YAML where a new entry can be added without having to change existing ones.
devversion
force-pushed
the
build/improve-size-golden
branch
from
13c1fa0 to
b997d45
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jun 13, 2020
* build: move nav-list size-test into dedicated `list` folder For consistency with other size-tests's we are going to add, we should move the nav-list one into a folder that is dedicated for list size tests. * build: switch to yaml file for size test golden Switches the size-test golden from a JSON file to a Yaml file. The motivation is that JSON files quickly can result in merge conflicts. This is mostly because of trailing commas that need to be added when new entries are added to the size-test golden. This should be improved with YAML where a new entry can be added without having to change existing ones.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the size-test golden from a JSON file to a Yaml
file. The motivation is that JSON files quickly can result
in merge conflicts. This is mostly because of trailing commas
that need to be added when new entries are added to the size-test
golden. This should be improved with YAML where a new entry can
be added without having to change existing ones.
Note: Marking as P2 because it would be good to get that in before I start sending more individual PRs for other components affected by light-weight tokens.