Skip to content

build: remove jelbourn from top-level files as reviewer #19598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Upon personal request, this commit removes Jeremy from the
top-level file review requests. These are primarily dev-infra
related and rather seem to cause undesired noise.

While being at it, the file has been updated so that the .github
folder is primarily owned by dev-infra, while other specific files
like codeowners and issue templates have more dedicated reviewers.

@devversion devversion requested review from jelbourn and a team as code owners June 10, 2020 18:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2020
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jun 10, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 10, 2020
Upon personal request, this commit removes Jeremy from the
top-level file review requests. These are primarily dev-infra
related and rather seem to cause undesired noise.

While being at it, the file has been updated so that the `.github`
folder is primarily owned by dev-infra, while other specific files
like codeowners and issue templates have more dedicated reviewers.
@devversion devversion force-pushed the build/update-codeowners-file branch from a56e1dd to c38e50f Compare June 12, 2020 08:11
@andrewseguin andrewseguin merged commit a9cabf5 into angular:master Jun 12, 2020
andrewseguin pushed a commit that referenced this pull request Jun 12, 2020
Upon personal request, this commit removes Jeremy from the
top-level file review requests. These are primarily dev-infra
related and rather seem to cause undesired noise.

While being at it, the file has been updated so that the `.github`
folder is primarily owned by dev-infra, while other specific files
like codeowners and issue templates have more dedicated reviewers.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants