Skip to content

test(slide-toggle): add performance tests for mat-slide-toggle #19572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

test(slide-toggle): add performance tests for mat-slide-toggle #19572

merged 3 commits into from
Jun 26, 2020

Conversation

wagnermaciel
Copy link
Contributor

Overview

  • Test the render speed of a slide toggle
  • Test the click speed between of a slide toggle

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 9, 2020
@wagnermaciel wagnermaciel marked this pull request as ready for review June 9, 2020 01:48
@wagnermaciel wagnermaciel requested a review from a team as a code owner June 9, 2020 01:48
devversion
devversion reviewed Jun 9, 2020
View reviewed changes
@wagnermaciel wagnermaciel requested a review from devversion June 9, 2020 18:46
@devversion devversion added lgtm target: patch This PR is targeted for the next patch release labels Jun 10, 2020
@devversion
Copy link
Member

devversion commented Jun 10, 2020 •
edited
Loading

@wagnermaciel I've marked this as LGTM and added appropriate labels. Looks like this PR needs a rebase. Could you rebase and add merge ready when done?

@wagnermaciel wagnermaciel force-pushed the slide-toggle-benchmark branch from d9a423f to c8a4de3 Compare June 19, 2020 21:55
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 22, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 26, 2020
@jelbourn jelbourn merged commit 55c39d8 into angular:master Jun 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 27, 2020
@wagnermaciel wagnermaciel deleted the slide-toggle-benchmark branch January 14, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wagnermaciel @devversion @jelbourn @googlebot