-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor: assert value for RxJS v7 compatibility #19569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmalerba PTAL
All the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d45640d
to
2dd93f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MichaelJamesParsons can you update the API gold for snackbar?
|
The shorthand for updating the golden is |
eb06685
to
716b787
Compare
Done |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In RxJS v7, the type of
Subject.next()
will change fromnext(value?: T)
tonext(value: T)
(change). No runtime behavior is affected, but this change will break users who build from source. This PR corrects types to ensure projects build successfully.Changes
T|undefined|null
values toT
where appropriate.Subject<any>
toSubject<void>
so thenext()
method can be called without passing an argument.