test(radio): add performance tests for mat-radio-button #19552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Jun 8, 2020
| await runBenchmark({ | ||
| id: 'render-two-radio-buttons', | ||
| url: '', | ||
| ignoreBrowserSynchronization: true, |
There was a problem hiding this comment.
Out of curiosity: Should we disable browser synchronization by default? We set it quite often and it feels unnecessary to repeat that everywhere? Surely can be a follow-up 😄
There was a problem hiding this comment.
Sure, should be a simple change 👍
devversion
approved these changes
Jun 9, 2020
devversion
reviewed
Jun 9, 2020
devversion
approved these changes
Jun 9, 2020
devversion
added
lgtm
target: patch
wagnermaciel
force-pushed
the
radio-benchmark
branch
from
b8461a8 to
9a8c016
Compare
devversion
approved these changes
Jun 22, 2020
mmalerba
pushed a commit
that referenced
this pull request
Jul 10, 2020
* test(radio): add performance tests for mat-radio-button * fixup! test(radio): add performance tests for mat-radio-button * fixup! test(radio): add performance tests for mat-radio-button * fixup! test(radio): add performance tests for mat-radio-button * fixup! test(radio): add performance tests for mat-radio-button * fixup! test(radio): add performance tests for mat-radio-button
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview