Skip to content

test(button): add performance tests for mat-raised-button #19545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2020
Merged

test(button): add performance tests for mat-raised-button #19545

merged 1 commit into from
Jun 26, 2020

Conversation

wagnermaciel
Copy link
Contributor

@wagnermaciel wagnermaciel commented Jun 5, 2020 •
edited
Loading

Overview

  • Test the render speed
  • Test the click speed
  • Small changes to checkbox benchmark

@wagnermaciel wagnermaciel requested review from jelbourn and a team as code owners June 5, 2020 03:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 5, 2020
@wagnermaciel wagnermaciel changed the title test(button): add performance tests for mat-raised-button test(button): Add performance tests for mat-raised-button Jun 5, 2020
@wagnermaciel wagnermaciel changed the title test(button): Add performance tests for mat-raised-button test(button): add performance tests for mat-raised-button Jun 5, 2020
devversion
devversion reviewed Jun 5, 2020
View reviewed changes
@wagnermaciel wagnermaciel requested a review from devversion June 8, 2020 23:07
jelbourn
jelbourn reviewed Jun 9, 2020
View reviewed changes
devversion
devversion reviewed Jun 10, 2020
View reviewed changes
jelbourn
jelbourn approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm target: patch This PR is targeted for the next patch release labels Jun 19, 2020
@jelbourn
Copy link
Member

You can add merge-ready once CI is green

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Jun 19, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 26, 2020
@jelbourn jelbourn merged commit 286fd99 into angular:master Jun 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 27, 2020
@wagnermaciel wagnermaciel deleted the button-benchmark branch January 14, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wagnermaciel @jelbourn @devversion @googlebot