Skip to content

test(mat-table): add performance tests for mat-table #19544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 10, 2020
Merged

test(mat-table): add performance tests for mat-table #19544

merged 8 commits into from
Jul 10, 2020

Conversation

wagnermaciel
Copy link
Contributor

Overview

  • Test the render speed of the table for 10, 100, and 1000 rows with 5 cols
  • Test the render speed of the table for 5, 10, and 20 cols with 10 rows

@wagnermaciel wagnermaciel requested review from jelbourn and a team as code owners June 4, 2020 23:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2020
@wagnermaciel wagnermaciel force-pushed the table-benchmark branch 2 times, most recently from d046755 to 31ac819 Compare June 5, 2020 18:41
@wagnermaciel wagnermaciel changed the title test(mat-table): Add performance tests for mat-table test(mat-table): add performance tests for mat-table Jun 5, 2020
jelbourn
jelbourn reviewed Jun 9, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewseguin PTAL

devversion
devversion reviewed Jun 10, 2020
View reviewed changes
@jelbourn
Copy link
Member

cc @kseamon FYI

@jelbourn jelbourn requested a review from andrewseguin June 16, 2020 22:12
@wagnermaciel
test(benchmarks): Add performance tests for mat-table
e38ba40 
* Create BasicTable which is just a simple mat-table wrapper
* Test the render speed of the table for 10, 100, and 1000 rows with 5 cols
* Test the render speed of the table for 5, 10, and 20 cols with 10 rows
@wagnermaciel
fixup! test(benchmarks): Add performance tests for mat-table
4f91b06
@wagnermaciel
fixup! test(benchmarks): Add performance tests for mat-table
caba725
@wagnermaciel
Copy link
Contributor Author

Once PR #37695 gets merged in, I will come back and separate these templates into their own files.

jelbourn
jelbourn reviewed Jun 25, 2020
View reviewed changes
@wagnermaciel wagnermaciel requested a review from jelbourn July 8, 2020 18:35
@wagnermaciel
Copy link
Contributor Author

@jelbourn Comments addressed

@jelbourn jelbourn added the target: minor This PR is targeted for the next minor release label Jul 8, 2020
jelbourn
jelbourn approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add merge-ready label when ready

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Jul 9, 2020
@mmalerba mmalerba merged commit e538e14 into angular:master Jul 10, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 10, 2020
@wagnermaciel wagnermaciel deleted the table-benchmark branch January 14, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wagnermaciel @jelbourn @devversion @googlebot @mmalerba