Skip to content

docs(examples/cdk/overlay): add a simple overlay example #19419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 3, 2020
Merged

docs(examples/cdk/overlay): add a simple overlay example #19419

merged 21 commits into from
Jun 3, 2020

Conversation

andy9775
Copy link
Contributor

Create a simple overlay example along with bazel build configuration.
Update existing bazel build config to include new example.

@jelbourn @teflonwaffles

andy9775 added 8 commits May 21, 2020 19:12
@andy9775
doc(examples/cdk/overlay): add a basic component
cb55f3c 
Add a basic component in order to build out an example for the cdk
Overlay feature
@andy9775
build(examples/cdk/overlay): add bazel build config for overlay example
78978a5
@andy9775
build(examples/cdk/overlay): update root examples bazel build script
50f3c6c 
Include new Overlay example in root examples bazel build script
@andy9775
docs(examples/cdk/overlay): add overlay example component to dev-app
79e0bf3
@andy9775
build(examples/cdk/overlay): add bazel build script for overlay dev-app
08ce2cd
@andy9775
build(examples/cdk/overlay): update dev-app bazel to include overlay …
f998e43 
…example
@andy9775
docs(examples/cdk/overlay): update dev-app routing to include overlay
a76de2c
@andy9775
docs(examples/cdk/overlay): add a basic overlay example
eed1455 
Add a basic overlay example demonstrating how to use the overlay
directives in order to display a sub-view and connect it to a button
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2020
@andy9775 andy9775 requested a review from teflonwaffles May 22, 2020 00:24
crisbeto
crisbeto reviewed May 22, 2020
View reviewed changes
andy9775 added 11 commits May 22, 2020 11:39
@andy9775
docs(examples/cdk/overlay): remote unused constructor
42a8259
@andy9775
docs(examples/cdk/overlay): remote unnecessary boolean type
6c0085f
@andy9775
Merge branch 'master' of github.com:angular/components into example-b…
354c2f4 
…asic-overlay
@andy9775
docs(examples/cdk/overlay): move simple overlay example to existing d…
e763193 
…ev-app route
@andy9775
Revert "docs(examples/cdk/overlay): add overlay example component to …
5ab6161 
…dev-app"

This reverts commit 79e0bf3.
@andy9775
Revert "build(examples/cdk/overlay): add bazel build script for overl…
f58f199 
…ay dev-app"

This reverts commit 08ce2cd.
@andy9775
Revert "build(examples/cdk/overlay): update dev-app bazel to include …
d93828d 
…overlay example"

This reverts commit f998e43.
@andy9775
Revert "docs(examples/cdk/overlay): update dev-app routing to include…
ae0fbdc 
… overlay"

This reverts commit a76de2c.
@andy9775
docs(examples/cdk/overlay): remove long comment
7f57724 
Remove long component comment in order to prevent it from rendering
fully on the examples page as the title
@andy9775
docs(examples/cdk/overlay): remove angular material from overlay cdk …
db88f66 
…example
@andy9775
docs(examples/cdk/overlay): fix css linting errors on overlay example
753cffa
@andy9775 andy9775 requested a review from crisbeto May 22, 2020 17:15
jelbourn
jelbourn approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small comment

@jelbourn jelbourn added target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels May 27, 2020
@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels May 28, 2020
@jelbourn jelbourn merged commit 72c38f7 into angular:master Jun 3, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@teflonwaffles teflonwaffles Awaiting requested review from teflonwaffles

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy9775 @jelbourn @crisbeto @googlebot