Skip to content

fix(material-experimental/mdc-slider): remove slider theme from all-theme #19411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

fix(material-experimental/mdc-slider): remove slider theme from all-theme #19411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/material-experimental/mdc-theming/_all-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
@import '../mdc-menu/menu-theme';
@import '../mdc-radio/radio-theme';
@import '../mdc-slide-toggle/slide-toggle-theme';
@import '../mdc-slider/slider-theme';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this prevent us from catching any bugs in the dev app until MDC are done updating their slider? It might be better to leave it as it is and then swap it out when MDC have released the rewrite.

@import '../mdc-tabs/tabs-theme';
@import '../mdc-table/table-theme';
@import '../mdc-progress-bar/progress-bar-theme';
Expand All @@ -30,7 +29,6 @@
@include mat-mdc-table-theme($theme-or-color-config);
@include mat-mdc-form-field-theme($theme-or-color-config);
@include mat-mdc-input-theme($theme-or-color-config);
@include mat-mdc-slider-theme($theme-or-color-config);
@include mat-mdc-tabs-theme($theme-or-color-config);
}
}