-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: run saucelabs tests with bazel #19409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3668cb
to
4db1296
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jul 17, 2020
We keep adding more tests to our codebase, but browsers on Saucelabs generally run slow. During the last couple of weeks unit tests on Saucelabs sometimes failed due to the default 10min timeout. e.g. https://app.saucelabs.com/tests/bfb7ade4b0fc4e7e9ff7237074baac80 We bump the timeout so that tests can complete without us relaunching another instance of a browser (which might pass; but will increase CI duration even more). We use the maximum value of 1000seconds. Ideally we'll fix this in the future by having incremental test runs. I'm working on this with a Bazel setup as a side project. See: #19409
andrewseguin
pushed a commit
that referenced
this pull request
Jul 17, 2020
We keep adding more tests to our codebase, but browsers on Saucelabs generally run slow. During the last couple of weeks unit tests on Saucelabs sometimes failed due to the default 10min timeout. e.g. https://app.saucelabs.com/tests/bfb7ade4b0fc4e7e9ff7237074baac80 We bump the timeout so that tests can complete without us relaunching another instance of a browser (which might pass; but will increase CI duration even more). We use the maximum value of 1000seconds. Ideally we'll fix this in the future by having incremental test runs. I'm working on this with a Bazel setup as a side project. See: #19409 (cherry picked from commit 80e4d3f)
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
We keep adding more tests to our codebase, but browsers on Saucelabs generally run slow. During the last couple of weeks unit tests on Saucelabs sometimes failed due to the default 10min timeout. e.g. https://app.saucelabs.com/tests/bfb7ade4b0fc4e7e9ff7237074baac80 We bump the timeout so that tests can complete without us relaunching another instance of a browser (which might pass; but will increase CI duration even more). We use the maximum value of 1000seconds. Ideally we'll fix this in the future by having incremental test runs. I'm working on this with a Bazel setup as a side project. See: angular#19409
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
We keep adding more tests to our codebase, but browsers on Saucelabs generally run slow. During the last couple of weeks unit tests on Saucelabs sometimes failed due to the default 10min timeout. e.g. https://app.saucelabs.com/tests/bfb7ade4b0fc4e7e9ff7237074baac80 We bump the timeout so that tests can complete without us relaunching another instance of a browser (which might pass; but will increase CI duration even more). We use the maximum value of 1000seconds. Ideally we'll fix this in the future by having incremental test runs. I'm working on this with a Bazel setup as a side project. See: angular#19409
38c1bd5
to
f36132e
Compare
f36132e
to
f6311a2
Compare
9258081
to
03e7a2e
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.