Skip to content

build: fix wrong anchors in docs #19375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

build: fix wrong anchors in docs #19375

merged 1 commit into from
May 15, 2020

Conversation

crisbeto
Copy link
Member

Fixes a failure in the docs generation task due to a couple of wrong links.

@crisbeto
build: fix wrong anchors in docs
4bde4cb 
Fixes a failure in the docs generation task due to a couple of wrong links.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels May 15, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner May 15, 2020 17:50
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 15, 2020
mmalerba
mmalerba approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label May 15, 2020
devversion
devversion approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for fixing this! We should really start building the docs-content on PRs

As discussed on Slack; it might be okay that the fragment case is different, as it would still match, but we want to enforce consistent lower-case fragments. This is fine!

jelbourn
jelbourn approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 948dfa9 into angular:master May 15, 2020
mmalerba pushed a commit that referenced this pull request May 15, 2020
@crisbeto @mmalerba
build: fix wrong anchors in docs (#19375)
bad049c
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@devversion devversion

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @mmalerba @googlebot