Skip to content

fix(dialog): focus recapturing not accounting for autoFocus option #19356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

fix(dialog): focus recapturing not accounting for autoFocus option #19356

merged 1 commit into from
May 21, 2020

Conversation

crisbeto
Copy link
Member

In #18826 we added some logic to recapture focus if the user clicks on a disabled backdrop. The problem is that we didn't account for the autoFocus config option.

Fixes #19350.

@crisbeto
fix(dialog): focus recapturing not accounting for autoFocus option
b7891e4 
In angular#18826 we added some logic to recapture focus if the user clicks on a disabled backdrop. The problem is that we didn't account for the `autoFocus` config option.

Fixes angular#19350.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 14, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner May 14, 2020 16:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2020
jelbourn
jelbourn approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 15, 2020
@jelbourn jelbourn merged commit 72b0219 into angular:master May 21, 2020
jelbourn pushed a commit that referenced this pull request May 21, 2020
@crisbeto @jelbourn
fix(dialog): focus recapturing not accounting for autoFocus option (#…
53ea1db 
…19356)

In #18826 we added some logic to recapture focus if the user clicks on a disabled backdrop. The problem is that we didn't account for the `autoFocus` config option.

Fixes #19350.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modals : Clicking on the backdrop automatically focuses on the first field
3 participants
@crisbeto @jelbourn @googlebot