Skip to content

fix(table): incorrectly sticking multiple footer rows #19321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020
Merged

fix(table): incorrectly sticking multiple footer rows #19321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/cdk/table/sticky-styler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,14 @@ export class StickyStyler {
}

// If positioning the rows to the bottom, reverse their order when evaluating the sticky
// position such that the last row stuck will be "bottom: 0px" and so on.
const rows = position === 'bottom' ? rowsToStick.reverse() : rowsToStick;
// position such that the last row stuck will be "bottom: 0px" and so on. Note that the
// sticky states need to be reversed as well.
const rows = position === 'bottom' ? rowsToStick.slice().reverse() : rowsToStick;
const states = position === 'bottom' ? stickyStates.slice().reverse() : stickyStates;

let stickyHeight = 0;
for (let rowIndex = 0; rowIndex < rows.length; rowIndex++) {
if (!stickyStates[rowIndex]) {
if (!states[rowIndex]) {
continue;
}

Expand Down
14 changes: 11 additions & 3 deletions src/cdk/table/table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,14 @@ describe('CdkTable', () => {
expectNoStickyStyles(footerRows);
});

it('should stick the correct footer row', () => {
component.stickyFooters = ['footer-3'];
fixture.detectChanges();

expectStickyStyles(footerRows[2], '10', {bottom: '0px'});
expectNoStickyStyles([footerRows[0], footerRows[1]]);
});

it('should stick and unstick left columns', () => {
component.stickyStartColumns = ['column-1', 'column-3'];
fixture.detectChanges();
Expand Down Expand Up @@ -1010,11 +1018,11 @@ describe('CdkTable', () => {
});

let footerCells = getFooterCells(footerRows[0]);
expectStickyStyles(footerRows[0], '10', {bottom: '0px'});
expectStickyStyles(footerRows[2], '10', {bottom: '0px'});
expectStickyStyles(footerCells[0], '1', {left: '0px'});
expectStickyStyles(footerCells[5], '1', {right: '0px'});
expectNoStickyStyles([footerCells[1], footerCells[2], footerCells[3], footerCells[4]]);
expectNoStickyStyles([footerRows[1], footerRows[2]]);
expectNoStickyStyles([footerRows[0], footerRows[1]]);

component.stickyHeaders = [];
component.stickyFooters = [];
Expand Down Expand Up @@ -1179,7 +1187,7 @@ describe('CdkTable', () => {
expectNoStickyStyles([cells[1], cells[2], cells[3], cells[4]]);
});

const footerCells = getFooterCells(footerRows[0]);
const footerCells = getFooterCells(footerRows[2]);
expectStickyStyles(footerCells[0], '11', {bottom: '0px', left: '0px'});
expectStickyStyles(footerCells[1], '10', {bottom: '0px'});
expectStickyStyles(footerCells[2], '10', {bottom: '0px'});
Expand Down