Skip to content

build: fix breaking changes script compilation error #19300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 9, 2020

It seems like using the RC of TS 3.9 causes a typing mismatch which breaks the breaking-changes script. Temporarily switches to using 3.8.

It seems like using the RC of TS 3.9 causes a typing mismatch which breaks the `breaking-changes` script. Temporarily switches to using 3.8.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe labels May 9, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners May 9, 2020 14:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2020
@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels May 11, 2020
@mmalerba mmalerba merged commit 2817d0f into angular:master May 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants