Skip to content

build: add dev app for MDC sidenav #19282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

build: add dev app for MDC sidenav #19282

merged 1 commit into from
May 7, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 7, 2020

Sets up a place in the dev app to make it easier to debug the MDC sidenav.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels May 7, 2020
@crisbeto crisbeto requested review from jelbourn and mmalerba as code owners May 7, 2020 19:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 7, 2020
mmalerba
mmalerba approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the lgtm label May 7, 2020
@crisbeto
build: add dev app for MDC sidenav
4e148a4 
Sets up a place in the dev app to make it easier to debug the MDC sidenav.
@crisbeto crisbeto force-pushed the mdc-sidenav-dev-app branch from 8fccb81 to 4e148a4 Compare May 7, 2020 19:51
@crisbeto crisbeto requested a review from a team as a code owner May 7, 2020 19:51
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 7, 2020
@jelbourn jelbourn merged commit a4171e0 into angular:master May 7, 2020
jelbourn pushed a commit that referenced this pull request May 7, 2020
@crisbeto @jelbourn
build: add dev app for MDC sidenav (#19282)
322efa0 
Sets up a place in the dev app to make it easier to debug the MDC sidenav.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @mmalerba @jelbourn @googlebot