Skip to content

refactor(drag-drop): remove deprecated APIs for version 10 #19280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 7, 2020

Removes some deprecated APIs that were marked to be removed in v10. Also marks some more APIs that were supposed to deprecated.

BREAKING CHANGES:

  • CdkDropList.start has been removed.
  • CdkDropList.drop has been removed.
  • CdkDropList.enter has been removed.
  • CdkDropList.exit has been removed.
  • CdkDropList.getItemIndex has been removed.
  • CDK_DRAG_CONFIG_FACTORY has been removed.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 7, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 7, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 7, 2020
Removes some deprecated APIs that were marked to be removed in v10. Also marks some more APIs that were supposed to deprecated.

BREAKING CHANGES:
* `CdkDropList.start` has been removed.
* `CdkDropList.drop` has been removed.
* `CdkDropList.enter` has been removed.
* `CdkDropList.exit` has been removed.
* `CdkDropList.getItemIndex` has been removed.
* `CDK_DRAG_CONFIG_FACTORY` has been removed.
@crisbeto crisbeto force-pushed the drag-drop-v10-deprecations branch from f3f8a19 to a0d168d Compare May 7, 2020 18:22
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 7, 2020
@mmalerba mmalerba merged commit de128e8 into angular:master May 13, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants