fix(column-resize): Resize table as well as columns, improve handing … #19264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of min/max width, and simplify overlay positioning.
googlebot
added
the
cla: yes
jelbourn
reviewed
May 6, 2020
| @@ -61,6 +63,10 @@ export abstract class ColumnResize implements AfterViewInit, OnDestroy { | |||
| return `cdk-column-resize-${this.selectorId}`; | |||
| } | |||
|
|
|||
| setResized() { | |||
| this.elementRef.nativeElement!.classList.add(WITH_RESIZED_COLUMN_CLASS); | |||
There was a problem hiding this comment.
Why does this need to be called from other classes instead of only responding to the resize stream?
There was a problem hiding this comment.
I went back and forth on this - I was not sure that applying a min/max size should trigger the notifier, which will eventually have side effects like persisting the size setting.
crisbeto
reviewed
May 6, 2020
src/components-examples/material-experimental/column-resize/opt-in/opt-in-column-resize-demo.ts
Outdated
Show resolved
Hide resolved
...es/material-experimental/column-resize/default-enabled/default-enabled-column-resize-demo.ts
Outdated
Show resolved
Hide resolved
src/cdk-experimental/column-resize/column-resize-directives/column-resize-flex.ts
Outdated
Show resolved
Hide resolved
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of min/max width, and simplify overlay positioning.