Skip to content

refactor: update api for embedded example comments in md docs #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented May 4, 2020

add more parameters to embedded example comments in md docs to be rendered into example components to implement compact view for example components in material docs page

@annieyw annieyw requested review from atscott and mmalerba May 4, 2020 18:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 4, 2020
@annieyw annieyw marked this pull request as ready for review May 4, 2020 21:40
@annieyw annieyw requested a review from a team as a code owner May 4, 2020 21:40
@devversion devversion added the target: patch This PR is targeted for the next patch release label May 4, 2020
@annieyw annieyw changed the title update api for embedded example comments in md docs refactor: update api for embedded example comments in md docs May 5, 2020
@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels May 7, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 703b1da into angular:master May 8, 2020
jelbourn pushed a commit that referenced this pull request May 8, 2020
* update example comment api in md to html renderer

* support for old and new api before docs are updated

* stringify lines to preserve brackets

Co-authored-by: Annie Wang <annieyw@google.com>
@annieyw annieyw deleted the examplesapi branch May 8, 2020 19:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants