feat(google-maps): Add KML Layer component to Google Maps #19226
Conversation
googlebot
added
the
cla: yes
mbehrlich
added
P3
| export class MapKmlLayer implements OnInit, OnDestroy { | ||
| private _eventManager = new MapEventManager(this._ngZone); | ||
| private readonly _options = new BehaviorSubject<google.maps.KmlLayerOptions>({}); | ||
| private readonly _url = new BehaviorSubject<string>(''); |
There was a problem hiding this comment.
This will pass an empty string to the map if we subscribe before the url has been assigned. Would that result in an error from the Maps API? We could use a ReplaySubject here instead.
There was a problem hiding this comment.
Url is also in options, so this allows the user to specify url as its own property, or to just include it as an option. Url is also allowed to be an empty string or undefined by the api, so it should not cause errors if the user uses an empty string on purpose.
jelbourn
added
blocked
|
FYI, we're feature-frozen right now leading up to the v10 RC. We should be able to merge in ~2 weeks. |
jelbourn
added
action: merge
Implement KML layers in @angular/google-maps. This allows users to specify a .kml file that configures many options that display on a Google Map. See https://developers.google.com/maps/documentation/javascript/reference/kml
Remove non-null assertions from KML Layer component.
Add exportAs to the directive to match the other components.
Fix test failure caused by merge.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Implement KML layers in @angular/google-maps. This allows users to
specify a .kml file that configures many options that display on a
Google Map. See
https://developers.google.com/maps/documentation/javascript/reference/kml