Skip to content

fix(tabs): don't prevent default space/enter action if active tab doesn't change #19207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

fix(tabs): don't prevent default space/enter action if active tab doesn't change #19207

merged 1 commit into from
May 8, 2020

Conversation

crisbeto
Copy link
Member

Switches to only preventing the default enter/space action if we did something with the event, otherwise we risk interfering with other user events.

Fixes #19190.

@crisbeto
fix(tabs): don't prevent default space/enter action if action tab doe…
360bb77 
…sn't change

Switches to only preventing the default enter/space action if we did something with the event, otherwise we risk interfering with other user events.

Fixes angular#19190.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 29, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner April 29, 2020 17:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 29, 2020
@crisbeto crisbeto changed the title fix(tabs): don't prevent default space/enter action if action tab doesn't change fix(tabs): don't prevent default space/enter action if active tab doesn't change Apr 29, 2020
jelbourn
jelbourn approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 6, 2020
@jelbourn jelbourn merged commit b38c812 into angular:master May 8, 2020
jelbourn pushed a commit that referenced this pull request May 8, 2020
@crisbeto @jelbourn
fix(tabs): don't prevent default space/enter action if action tab doe…
7a4128b 
…sn't change (#19207)

Switches to only preventing the default enter/space action if we did something with the event, otherwise we risk interfering with other user events.

Fixes #19190.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug([mat-tab]): unable to use space in an input within mat-tab-label
3 participants
@crisbeto @jelbourn @googlebot