fix(material-experimental/mdc-button): strong focus indication always visible on fab buttons #19169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Apr 25, 2020
… visible on fab buttons Our generic strong focus indication uses `::before` which is also used by MDC's FAB to draw a transparent border for high contrast mode. The result is that our indication is always visible and not positioned properly. These changes move the indicator into an inner element whose `::before` isn't styled by MDC.
crisbeto
force-pushed
the
mdc-fab-focus-indicator
branch
from
9dbfb90 to
759dc12
Compare
|
The feedback has been addressed. |
|
@zelliott PTAL |
jelbourn
pushed a commit
that referenced
this pull request
Apr 29, 2020
… visible on fab buttons (#19169) Our generic strong focus indication uses `::before` which is also used by MDC's FAB to draw a transparent border for high contrast mode. The result is that our indication is always visible and not positioned properly. These changes move the indicator into an inner element whose `::before` isn't styled by MDC.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our generic strong focus indication uses
::beforewhich is also used by MDC's FAB to draw a transparent border for high contrast mode. The result is that our indication is always visible and not positioned properly. These changes move the indicator into an inner element whose::beforeisn't styled by MDC.