Skip to content

refactor(schematics): remove comments in collection.json #19077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020
Merged

refactor(schematics): remove comments in collection.json #19077

merged 1 commit into from
Apr 17, 2020

Conversation

cyrilletuzi
Copy link
Contributor

Remove comments in collection.json so it is valid JSON.

Fixes #19076

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 15, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm good with this change. This mostly a leftover from the initial schematics anyway.

Can we please update the commit message to not refer to this as a fix? This is working as expected for the Angular CLI devkit which uses JSON5. Maybe refactor describes this best.

@devversion devversion added lgtm target: patch This PR is targeted for the next patch release labels Apr 15, 2020
@cyrilletuzi cyrilletuzi changed the title fix(schematics): remove comments in collection.json refactor(schematics): remove comments in collection.json Apr 15, 2020
@cyrilletuzi
Copy link
Contributor Author

@devversion Done.

This mostly a leftover from the initial schematics anyway.

Aside question: can you elaborate about that? Is there other schematics I should be aware of (to enable them in my VS Code extension)?

@devversion
Copy link
Member

@cyrilletuzi Thanks!

With leftover I meant that we seem to don't need these comments in the collection. The actual schematic description field should be sufficient. That's why the CDK doesn't seem to have comments in the schematic collection, nor do we have comments in the migration collections.

@devversion devversion added action: merge The PR is ready for merge by the caretaker merge safe labels Apr 15, 2020
@andrewseguin andrewseguin merged commit 7d47b45 into angular:master Apr 17, 2020
andrewseguin pushed a commit that referenced this pull request Apr 17, 2020
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(schematics): invalid collection.json due to comments
4 participants