Skip to content

build: update to bazel v3.0.0 #19033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

build: update to bazel v3.0.0 #19033

merged 1 commit into from
Apr 17, 2020

Conversation

devversion
Copy link
Member

@devversion devversion commented Apr 9, 2020 •
edited
Loading

Updates to Bazel v3.0.0. Primarily the motiviation for this is
that it contains a fix for Windows bazel run <..>. This previously
broke since the workspace directory is no longer created in the
runfiles directory. This causes targets like unit_tests_local to fail.

bazelbuild/bazel@02ce5bd

@devversion
build: update to bazel v3.0.0
ee8c96b 
Updates to Bazel v3.0.0. Primarily the motiviation for this is
that it contains a fix for Windows `bazel run <..>`. This previously
broke since the workspace directory is no longer created in the
runfiles directory. This causes targets like `unit_tests_local` to fail.
@devversion devversion requested review from jelbourn and a team as code owners April 9, 2020 17:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 9, 2020
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Apr 9, 2020
josephperrott
josephperrott requested changes Apr 9, 2020
View reviewed changes
.bazelversion
@@ -1 +1 @@
2.1.0
3.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 3.0.1 correct? so that it matches the peer dep of the bazel_toolchain?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no Bazel 3.0.1 unless I miss something here. The toolcbain repo is not really always in sync w/ Bazel based on how they released in the past.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right, I was under the impression they were in sync.

josephperrott
josephperrott approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.bazelversion
@@ -1 +1 @@
2.1.0
3.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, you're right, I was under the impression they were in sync.

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 10, 2020
@andrewseguin andrewseguin merged commit 98cb57d into angular:master Apr 17, 2020
andrewseguin pushed a commit that referenced this pull request Apr 17, 2020
@devversion @andrewseguin
build: update to bazel v3.0.0 (#19033)
1b70d90 
Updates to Bazel v3.0.0. Primarily the motiviation for this is
that it contains a fix for Windows `bazel run <..>`. This previously
broke since the workspace directory is no longer created in the
runfiles directory. This causes targets like `unit_tests_local` to fail.

(cherry picked from commit 98cb57d)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@devversion @soro-google
build: update to bazel v3.0.0 (angular#19033)
e933f5c 
Updates to Bazel v3.0.0. Primarily the motiviation for this is
that it contains a fix for Windows `bazel run <..>`. This previously
broke since the workspace directory is no longer created in the
runfiles directory. This causes targets like `unit_tests_local` to fail.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devversion @josephperrott @jelbourn @googlebot @mmalerba @andrewseguin