build: add try/catch to @angular/bazel ng_module patch #18985
Conversation
Navigating the angular/angular & angular/components dependency sandwich.
googlebot
added
the
cla: yes
devversion
added
lgtm
action: merge
| try { | ||
| // Temporary patch pre-req for https://github.com/angular/angular/pull/36333. | ||
| // Can be removed once @angular/bazel is updated here to include this patch. | ||
| // try/catch needed for this the material CI tests to work in angular/repo |
There was a problem hiding this comment.
Could you elaborate more on the specifics of why the try-catch is necessary?
There was a problem hiding this comment.
The patch fails to apply in the angular repo for some reason so the try/catch is needed to make angular/angular#36333 green.
@devversion Do you remember the specifics? I've put this in once before to manage the dependency sandwich but can't recall what the underlying mechanics are of the patch failing.
There was a problem hiding this comment.
Ahh. I think I sorted it out in my head. The patch is applied cleanly in the components repo as it is applied to the last released @angular/bazel. However, in the angular repo. the patch is applied to the head @angular/bazel, which in the PR that change is actually made and where the components repo has to be updated to be green, the patch is applied to an @angular/bazel package that already has the changes in the patch. So it fails to apply and it will take the catch() code path.
There was a problem hiding this comment.
Yep. Can confirm that this is why we need the try/catch.
Navigating the angular/angular & angular/components dependency sandwich.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Navigating the angular/angular & angular/components dependency sandwich.