-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material-experimental/mdc-chips): support custom errorStateMatcher #18974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MatChipGrid should have an errorStateMatcher Input in order to be backwards compatible with the old non-mdc MatChipList.
Is this just a no-op because only the mat-chip-listbox should actually be used with an input? If that's the case then maybe we shouldn't add this back. We'll just document it as a breaking change to be aware of and recommend that people use the listbox version with inputs. |
mat-chip-grid is the one that gets used with matChipInputFor. So I think we still want it! There's a use case in Pantheon that I'm trying to migrate to mat-chip-grid where someone is using their own errorStateMatcher. |
But don't we need to do something with |
Oh haha I see what you're saying! It does look like that. I think it's being used here in mixinErrorState: https://github.com/angular/components/blob/master/src/material/core/common-behaviors/error-state.ts#L55 which is part of _MatChipGridMixinBase |
Ahh ok, figured it was just me being dumb |
MatChipGrid should have an errorStateMatcher Input in order to be backwards compatible with the old non-mdc MatChipList.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
MatChipGrid should have an errorStateMatcher Input in order to be
backwards compatible with the old non-mdc MatChipList.