Skip to content

fix(sidenav): run autosize debounce timer outside the NgZone #18898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

fix(sidenav): run autosize debounce timer outside the NgZone #18898

merged 1 commit into from
Jul 29, 2020

Conversation

crisbeto
Copy link
Member

Fixes the timer that we use to debounce the autosize calls being run inside the NgZone.

Fixes #18894.

@crisbeto
fix(sidenav): run autosize debounce timer outside the NgZone
be0f20b 
Fixes the timer that we use to debounce the autosize calls being run inside the NgZone.

Fixes angular#18894.
@crisbeto crisbeto added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 23, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner March 23, 2020 17:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 23, 2020
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 23, 2020
@crisbeto crisbeto mentioned this pull request Mar 23, 2020
Closed
mmalerba
mmalerba approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels May 2, 2020
@jelbourn jelbourn merged commit 27e3b9d into angular:master Jul 29, 2020
jelbourn pushed a commit that referenced this pull request Jul 29, 2020
@crisbeto @jelbourn
fix(sidenav): run autosize debounce timer outside the NgZone (#18898)
02210d8 
Fixes the timer that we use to debounce the autosize calls being run inside the NgZone.

Fixes #18894.

(cherry picked from commit 27e3b9d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

help([mat-sidenav-container]): [Autosize is blocking my Protractor tests]
4 participants
@crisbeto @mmalerba @jelbourn @googlebot