fix(input/testing): unable to set the value of inputs that don't respond to typing #18812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
18790/input-harness-value
branch
from
80d7670 to
34bc6de
Compare
devversion
reviewed
Mar 12, 2020
crisbeto
force-pushed
the
18790/input-harness-value
branch
from
34bc6de to
72ef642
Compare
|
@mmalerba I've reworked this based on our discussion. I'm also bumping up the priority since the issue has come up multiple times. |
crisbeto
added
P2
mmalerba
reviewed
May 11, 2020
…ond to typing The `setValue` method of the input harness is set up so that it types out the value in the input. This won't work for input that don't respond to typing (e.g. `color`). These changes add an extra call that also sets the `value` property of the input, on top of typing into it. Fixes angular#18790.
crisbeto
force-pushed
the
18790/input-harness-value
branch
from
72ef642 to
ccab78c
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Jun 10, 2020
…ond to typing (#18812) The `setValue` method of the input harness is set up so that it types out the value in the input. This won't work for input that don't respond to typing (e.g. `color`). These changes add an extra call that also sets the `value` property of the input, on top of typing into it. Fixes #18790.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setValuemethod of the input harness is set up so that it types out the value in the input. This won't work for inputs that don't respond to typing (e.g.color). These changes add an extra call that also sets thevalueproperty of the input, on top of typing into it.Fixes #18790.
Note: not sure whether the change to the
TestElementsignature needs to be made optional first.