Skip to content

build: ensure correct toolchains used for remote execution #18803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Currently the toolchains used for RBE are dependent on the current platform.
This breaks because the remote executors are k8 based, and the default
bazel-toolchain configurations do not work for anything except k8 or armeabi-v7a.

Currently the toolchains used for RBE are dependent on the
current platform. This breaks because there is no darwin toolchain.

We need to instruct Bazel to use the k8 linux toolchains when running
builds remotely.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 12, 2020
@devversion devversion requested review from jelbourn and a team as code owners March 12, 2020 10:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 12, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 12, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit e3d2051 into angular:master Mar 12, 2020
andrewseguin pushed a commit that referenced this pull request Mar 12, 2020
Currently the toolchains used for RBE are dependent on the
current platform. This breaks because there is no darwin toolchain.

We need to instruct Bazel to use the k8 linux toolchains when running
builds remotely.

(cherry picked from commit e3d2051)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants