Skip to content

feat(mat-paginator): Optionally style the mat-paginator form-field #18800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

dpurp
Copy link
Contributor

@dpurp dpurp commented Mar 12, 2020

Adds a new option to the MatPaginatorDefaultOptions that allows users to set the appearance of the page size form field in mat-paginator.

Fixes #16266

dpurp added 3 commits March 11, 2020 21:26
…field.

Adds a new option to the MatPaginatorDefaultOptions that allows users
to set the appearance of the page size form field in mat-paginator.
@dpurp dpurp requested a review from andrewseguin as a code owner March 12, 2020 05:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 12, 2020
@sdavids
Copy link

sdavids commented May 1, 2020

Right now, tables look really ugly if one uses

@NgModule({
...
  providers: [
    {
      provide: MAT_FORM_FIELD_DEFAULT_OPTIONS,
      useValue: {appearance: 'fill'},
    },
  ],
})
export class MaterialModule {}

to have the fill look for all form fields:

appearance

So this PR is appreciated!

@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels May 7, 2020
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
@jelbourn jelbourn added the target: minor This PR is targeted for the next minor release label Jul 29, 2020
@jelbourn jelbourn added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Jul 29, 2020
@jelbourn jelbourn merged commit f9c6d2a into angular:master Jul 29, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement feature This issue represents a new feature or feature request rather than a bug or bug fix G This is is related to a Google internal issue merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Paginator] Allow for "appearance" attribute
5 participants