Skip to content

fix(material-experimetal/mdc-form-field): account for breaking changes in MDC #18795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020
Merged

fix(material-experimetal/mdc-form-field): account for breaking changes in MDC #18795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"@types/youtube": "^0.0.38",
"@webcomponents/custom-elements": "^1.1.0",
"core-js": "^2.6.9",
"material-components-web": "6.0.0-canary.17b9699c4.0",
"material-components-web": "6.0.0-canary.d5808057f.0",
"rxjs": "^6.5.3",
"systemjs": "0.19.43",
"tslib": "^1.10.0",
Expand Down
17 changes: 6 additions & 11 deletions src/material-experimental/mdc-form-field/_mdc-text-field-structure-overrides.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,15 @@
border: none;
}

// Reset the padding that MDC sets on native input elements. We cannot rely on this
// spacing as we support arbitrary form-field controls which aren't necessarily matching
// the "mdc-text-field__input" class. Note: We need the first selector to overwrite the
// default no-label MDC padding styles which are set with a very high specificity.
// Reset the height that MDC sets on native input elements. We cannot rely on their
// fixed height as we handle vertical spacing differently. MDC sets a fixed height for
// inputs and modifies the baseline so that the textfield matches the spec. This does
// not work for us since we support arbitrary form field controls which don't necessarily
// use an `input` element. We organize the vertical spacing on the infix container.
.mdc-text-field--no-label:not(.mdc-text-field--textarea)
.mat-mdc-input-element.mdc-text-field__input,
.mat-mdc-text-field-wrapper .mat-mdc-input-element {
padding: 0;
height: auto;
}

// MDC adds vertical spacing to inputs. We removed this spacing and intend to add it
Expand Down Expand Up @@ -77,12 +78,6 @@
opacity: 1;
}

// We removed the horizontal inset on input elements, but need to re-add the spacing to
// the actual form-field flex container that contains the prefixes, suffixes and infix.
.mat-mdc-text-field-wrapper .mat-mdc-form-field-flex {
padding: 0 $mdc-text-field-input-padding;
}

// Since we moved the horizontal spacing from the input to the form-field flex container
// and the MDC floating label tries to account for the horizontal spacing, we need to reset
// the shifting since there is no padding the label needs to account for. Note that we do not
Expand Down
Loading