-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update to typescript v3.8 #18789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f6015f
to
d47cbad
Compare
Updates to TypeScript v3.8. To ensure that Angular Components is still compatible with older supported TypeScript versions, a new integration test has been introduced.
re-exported. This ensures that all entry-points can successfully compile. | ||
""" | ||
|
||
def generate_import_all_entry_points_file(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we could consolidate on a single, canonical list of packages for the repo? Right now I think there's a handful of places that need to be updated when we add a new package. Either that, or just documenting all the places that need to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Definitely agreed. I've been trying to reduce this type of duplication (as seen with entry-points in the system config etc.).
I'll work on a follow-up that gives us a better list of release packages. The problem always comes from the fact that we can't easily access these variables outside of Bazel (e.g. in the release scripts).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(other comment can be a follow-up)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates to TypeScript v3.8. To ensure that Angular Components is still
compatible with older supported TypeScript versions, a new integration
test has been introduced.
Unlike in
angular/angular
, our packages have a lot more entry-points, so manuallycreating files that import all entry-points for the compatibility test is not suitable. This
required a more dynamic and less verbose solution.
Also, audited all TypeScript AST work to check for the new AST changes from v3.8. It looks like there is no action needed, but the
class-name
ng-update
rule seems to need a general cleanup to handle namespaced exports/imports better. Added a comment w/ JIRA ticket.