Skip to content

build: update to typescript v3.8 #18789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 11, 2020

Updates to TypeScript v3.8. To ensure that Angular Components is still
compatible with older supported TypeScript versions, a new integration
test has been introduced.

Unlike in angular/angular, our packages have a lot more entry-points, so manually
creating files that import all entry-points for the compatibility test is not suitable. This
required a more dynamic and less verbose solution.

Also, audited all TypeScript AST work to check for the new AST changes from v3.8. It looks like there is no action needed, but the class-name ng-update rule seems to need a general cleanup to handle namespaced exports/imports better. Added a comment w/ JIRA ticket.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 11, 2020
@devversion devversion force-pushed the ts-3.8 branch 7 times, most recently from 9f6015f to d47cbad Compare March 11, 2020 16:49
Updates to TypeScript v3.8. To ensure that Angular Components is still
compatible with older supported TypeScript versions, a new integration
test has been introduced.
@devversion devversion added target: minor This PR is targeted for the next minor release merge safe P2 The issue is important to a large percentage of users, with a workaround labels Mar 11, 2020
@devversion devversion marked this pull request as ready for review March 11, 2020 18:36
@devversion devversion requested review from jelbourn and a team as code owners March 11, 2020 18:36
re-exported. This ensures that all entry-points can successfully compile.
"""

def generate_import_all_entry_points_file():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we could consolidate on a single, canonical list of packages for the repo? Right now I think there's a handful of places that need to be updated when we add a new package. Either that, or just documenting all the places that need to be updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Definitely agreed. I've been trying to reduce this type of duplication (as seen with entry-points in the system config etc.).

I'll work on a follow-up that gives us a better list of release packages. The problem always comes from the fact that we can't easily access these variables outside of Bazel (e.g. in the release scripts).

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(other comment can be a follow-up)

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 12, 2020
@andrewseguin andrewseguin merged commit b4d2838 into angular:master Mar 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants