Skip to content

docs(material/expansion-panel): throws No provider found for DateAdapter #18772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2020
Merged

docs(material/expansion-panel): throws No provider found for DateAdapter #18772

merged 1 commit into from
Mar 12, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Mar 9, 2020 •
edited
Loading

  • import MatNativeDateModule

Fixes #18771

I was able to reproduce this and verify the fix in the dev-app.

@Splaktar Splaktar added P2 The issue is important to a large percentage of users, with a workaround docs This issue is related to documentation area: dev-infra Issue related to internal project infrastructure target: patch This PR is targeted for the next patch release labels Mar 9, 2020
@Splaktar Splaktar requested a review from devversion March 9, 2020 23:47
@Splaktar Splaktar requested a review from jelbourn as a code owner March 9, 2020 23:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2020
crisbeto
crisbeto approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, kinda weird considering that we don't have a datepicker on the expansion panel demo.

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 10, 2020
devversion
devversion approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it makes sense since one of the examples use the datepicker.

https://github.com/angular/components/blob/master/src/components-examples/material/expansion/expansion-steps/expansion-steps-example.html#L65

@devversion devversion removed the area: dev-infra Issue related to internal project infrastructure label Mar 10, 2020
@geromegrignon geromegrignon mentioned this pull request Mar 11, 2020
Closed
@andrewseguin andrewseguin merged commit bcb36c2 into angular:master Mar 12, 2020
andrewseguin pushed a commit that referenced this pull request Mar 12, 2020
@Splaktar @andrewseguin
docs(material/expansion-panel): throws No provider found for DateAdap…
618585d 
…ter (#18772)

- import MatNativeDateModule

Fixes #18771

(cherry picked from commit bcb36c2)
@Splaktar Splaktar deleted the missing-date-adapter branch March 12, 2020 21:49
@crisbeto crisbeto mentioned this pull request Mar 14, 2020
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(material/expansion-panel): accordion example throws No provider found for DateAdapter
5 participants
@Splaktar @crisbeto @devversion @googlebot @andrewseguin