Skip to content

build: do not hide output of bazel yarn install #18765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

By default, the yarn_install output is hidden. We should enable
it so that we can see progress, or potential postinstall errors.

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 9, 2020
@devversion devversion requested review from jelbourn and a team as code owners March 9, 2020 18:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2020
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Mar 9, 2020

Failures related to this change?

@devversion devversion force-pushed the build/enable-verbose-yarn-install branch 2 times, most recently from 85c33ce to dc67316 Compare March 9, 2020 20:18
By default, the `yarn_install` output is hidden. We should enable
it so that we can see progress, or potential postinstall errors.
@devversion devversion force-pushed the build/enable-verbose-yarn-install branch from dc67316 to 065c1b5 Compare March 9, 2020 20:23
@devversion
Copy link
Member Author

@jelbourn Fixed. Looks like this is caused by an upstream Bazel bug (fix released soon).

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 9, 2020
@mmalerba mmalerba merged commit 00ede24 into angular:master Mar 9, 2020
mmalerba pushed a commit that referenced this pull request Mar 10, 2020
By default, the `yarn_install` output is hidden. We should enable
it so that we can see progress, or potential postinstall errors.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants