Skip to content

docs(sort): fix grammar in the 'sort' documentation #18751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2020
Merged

docs(sort): fix grammar in the 'sort' documentation #18751

merged 1 commit into from
Mar 9, 2020

Conversation

rewolf
Copy link
Contributor

@rewolf rewolf commented Mar 7, 2020

Changed some incorrect uses of "an" to "a". Removed a duplicate word.

@rewolf rewolf requested a review from andrewseguin as a code owner March 7, 2020 11:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 7, 2020
crisbeto
crisbeto approved these changes Mar 8, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed docs This issue is related to documentation lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 8, 2020
@crisbeto
Copy link
Member

crisbeto commented Mar 8, 2020

Commit message fixup: should be prefix with docs:.

@rewolf
Copy link
Contributor Author

rewolf commented Mar 9, 2020

@crisbeto What's the process of amending commits. Do I just force push an amended commit to the PR source ? (my fork/master)

@crisbeto
Copy link
Member

crisbeto commented Mar 9, 2020

Yes, you can just force push to the branch.

@rewolf
docs: Correct english on the sort.md
6e03b90 
Changed some incorrect uses of "an" to "a". Removed a duplicate word.
@mmalerba mmalerba changed the title Correct English in the 'sort' documentation docs(sort): fix grammar in the 'sort' documentation Mar 9, 2020
@mmalerba mmalerba merged commit 6af149c into angular:master Mar 9, 2020
mmalerba pushed a commit that referenced this pull request Mar 10, 2020
@rewolf @mmalerba
docs(sort): fix grammar in the 'sort' documentation (#18751)
dba68ad 
Changed some incorrect uses of "an" to "a". Removed a duplicate word.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rewolf @crisbeto @googlebot @mmalerba