fix(material-experimental/mdc-form-field): avoid expression changed a… #18741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter check There is currently a bug in the Angular Framework that results in ExpressionChangedAfterItHasBeenChecked errors not throwing when they should for OnPush components. Becuase we modify a variable used in the template after it was already checked (in ngAfterViewInit), we need to trigger change detection manually or the change might not be picked up.
googlebot
added
the
cla: yes
devversion
approved these changes
Mar 6, 2020
devversion
added
lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Mar 6, 2020
There is currently a bug in the Angular Framework that results in ExpressionChangedAfterItHasBeenChecked errors not throwing when they should for OnPush components. Becuase we modify a variable used in the template after it was already checked (in ngAfterViewInit), we need to trigger change detection manually or the change might not be picked up.
This was referenced Mar 28, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fter check
There is currently a bug in the Angular Framework that results in
ExpressionChangedAfterItHasBeenChecked errors not throwing when they
should for OnPush components. Because we modify a variable used in the
template after it was already checked (in ngAfterViewInit), we need to
trigger change detection manually or the change might not be picked up.
This was detected when running the CI for the fix in the framework to make
the error actually throw when it should: angular/angular#34443
Maybe also worth noting that the non-mdc form-field also calls
detectChangesto avoid this same problem:
components/src/material/form-field/form-field.ts
Lines 374 to 378 in e0634c9